dwsmith1983 commented on PR #5365: URL: https://github.com/apache/datafusion-comet/pull/5365#issuecomment-5605696104
Both items are in the head (a48544e45). Selected paths: `declineReason` now probes every distinct selected data-file and deletion-vector URI rather than their parent directories. The probe is a URL parse in the native library with no I/O, measured at 0.75 microseconds per file over 200,000 paths, so the per-file cost sits below the scan's own per-file work. The converted case is a test: a Parquet directory with one data file renamed to carry a newline, `CONVERT TO DELTA` keeping the basename, and the query falls back to Spark with the matching answer and a reason naming that file. On the previous head that table was claimed natively. Duplicate classes: the root pom no longer carries the comet-common exception. The exclusion alternative packages fine but fails the reactor test lifecycle with `NoClassDefFoundError: org/apache/comet/CometRuntimeException`, because a reactor test run resolves comet-spark from `target/classes` unshaded and the exclusion removes the only copy of those classes, so that option is out. The exception now lives in the contrib module's own enforcer execution, same execution id and `combine.children="append"`, so it extends the inherited rule for that module only. Validated with the delta profile: clean package, and clean test with DeltaScanContribSuite at 134; without the profile, validate shows no contrib module and no exception; the effective pom of the contrib module lists the root's dependencies plus comet-common; and the delta build gate script passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
