alamb commented on code in PR #12085: URL: https://github.com/apache/datafusion/pull/12085#discussion_r1723852056
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5364,6 +5364,11 @@ SELECT MAX(col0) FROM empty WHERE col0=1; ---- NULL +query I Review Comment: On main this query fails like this: ``` creatDataFusion CLI v41.0.0 > create table empty; 0 row(s) fetched. Elapsed 0.008 seconds. > select distinct count() from empty; CombinePartialFinalAggregate caused by Internal error: PhysicalOptimizer rule 'CombinePartialFinalAggregate' failed, due to generate a different schema, original schema: Schema { fields: [Field { name: "count()", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }], metadata: {} }, new schema: Schema { fields: [Field { name: "count()", data_type: Int64, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }], metadata: {} }. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org