dwsmith1983 commented on PR #5808: URL: https://github.com/apache/datafusion-comet/pull/5808#issuecomment-5618364918
Folded into #5654 as its last commit, with the items from the review above applied there: `parking_lot::Mutex` for the memo, one `throw_spark_error_json` with the `External` arm routed through the chain walk, the opener-skip explanation kept once on `FieldIdCheck`, `case_sensitive` threaded through the scan helper with the case-insensitive duplicate covered, root and `list<struct>` duplicate id cases added, and the root check narrowed to the columns a read references. Closing this one so there is a single reviewable change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
