adriangb commented on PR #25161: URL: https://github.com/apache/datafusion/pull/25161#issuecomment-5625322067
Minor merge-order note: https://github.com/apache/datafusion/pull/25175 (timezone characterization tests) has a `from_unixtime` block in Section 9 of `datafusion/sqllogictest/test_files/datetime/timestamps_timezone.slt`. No assertion in it breaks — that block runs with `datafusion.execution.time_zone` unset, where this PR deliberately keeps `Timestamp(Second, None)`. But the comment above it says `from_unixtime` "ignores `datafusion.execution.time_zone`", which stops being true once this lands. Whichever merges second should update the comment. Flagging it so the stale text does not survive review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
