viirya commented on code in PR #857:
URL: https://github.com/apache/datafusion-comet/pull/857#discussion_r1724441469


##########
.github/workflows/docker-publish.yml:
##########
@@ -44,8 +44,8 @@ jobs:
       - name: Extract Comet version
         id: extract_version
         run: |
-          COMET_VERSION=$(mvn help:evaluate -Dexpression=project.version -q 
-DforceStdout)
-          echo "COMET_VERSION=$COMET_VERSION" >> $GITHUB_ENV
+          # use the tag that triggered this workflow as the Comet version e.g. 
0.2.0-rc1
+          echo "COMET_VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV

Review Comment:
   Is this to fix `ghcr.io/apache/datafusion-comet:spark-3.4-scala-2.12-1`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to