dwsmith1983 commented on issue #1849: URL: https://github.com/apache/datafusion-comet/issues/1849#issuecomment-5636900516
The undefined behavior Miri flagged was fixed in #3652 (1772097ae), which also dropped the `#[cfg_attr(miri, ignore)]` that #1845 had put on the row test, and #3670 (a05c568e6) moved every `SparkUnsafeRow` accessor to aligned `ptr::read`. native/shuffle/src/spark_unsafe/row.rs now documents the 8-byte alignment invariant (base address, bitset width and field slots are all multiples of 8), the test fixtures allocate `#[repr(align(8))]` buffers, and the file carries no Miri ignores. The nightly Miri workflow (.github/workflows/miri.yml) runs `cargo miri test` across the workspace. Suggest closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
