Omega359 commented on code in PR #12097:
URL: https://github.com/apache/datafusion/pull/12097#discussion_r1725170498
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -261,11 +251,13 @@ enum ComparisonType {
Single,
}
-fn general_array_has_dispatch<O: OffsetSizeTrait>(
+/// Public function for internal benchmark, avoid to use it in production
+pub fn general_array_has_dispatch<O: OffsetSizeTrait>(
Review Comment:
My only thought was a wrapper function with a `#[cfg(test)] ` that is public
and the benchmark uses that. Slight overhead which likely isn't meaningful here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
