kosiew commented on PR #25051: URL: https://github.com/apache/datafusion/pull/25051#issuecomment-5644656206
@jayzhan211 > invoke_per_accumulator: state.size() is inside the timed region [e6e4a85](https://github.com/apache/datafusion/pull/25051/commits/e6e4a85a55cba9375bca4741806ad45a7497aa78) moved `sizes_pre` collection before the timer and `sizes_post` collection after it. Only `f(accumulator, values)` is timed, retaining one timer pair per prepared chunk. > A regression test ... an accumulator whose `size()` sleeps, asserting the recorded duration stays small — would lock this in. [e7d2d7e](https://github.com/apache/datafusion/pull/25051/commits/e7d2d7e4fa318436c2bbee520e5f7c3d8b9e73fc) added `adapter_grouped_update_excludes_size_accounting_from_metric`: `SlowSizeAccumulator::size()` sleeps 50 ms, while the grouped metric must remain below 25 ms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
