neilconway opened a new pull request, #25229: URL: https://github.com/apache/datafusion/pull/25229
## Which issue does this PR close? - Closes #25222. ## Rationale for this change Arrow allows elements of a ListArray to be logically NULL (according to the validity buffer), but to have a non-empty offset range. Such elements should be considered NULL. `array_append` and `array_prepend` only considered the offsets when computing the results of these functions, which resulted in mishandling such NULL values. ## What changes are included in this PR? * Fix bug in `array_append`, `array_prepend` * Update test expectations to remove incorrect expected behavior for FSLs * Add new tests * Clarify docs on `generic_append_and_prepend` NULL handling ## What is the testing strategy for this PR? Yes, new tests added. ## Are there any user-facing changes? Yes, bugs fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
