peterxcli commented on PR #5807: URL: https://github.com/apache/datafusion-comet/pull/5807#issuecomment-5651478125
> My field-number/reservation request is therefore a schema-maintenance convention, following [protobuf guidance](https://protobuf.dev/programming-guides/proto3/#assigning), not a promise of a stable mixed-version JNI ABI. The [same Comet policy](https://github.com/apache/datafusion-comet/blob/7e4c5e4139561f013480a39d263a936f541f5284/docs/source/about/versioning_policy.md#L59) explicitly excludes internal plan protobuf from its compatibility guarantees. @sunchao @andygrove my point is: if there’s no compatibility concern, this is a great opportunity for a code cleanup. If we keep the old code around indefinitely, the codebase will only grow harder to maintain. And we don’t lose anything by removing it -- the schema evolution is still fully traceable through git blame and the PR history. That said, I’m happy to keep it if there’s a compatibility case I’m missing. Would love to hear your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
