alamb commented on code in PR #12099:
URL: https://github.com/apache/datafusion/pull/12099#discussion_r1725449158
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -552,7 +552,9 @@ impl ExternalSorter {
let fetch = self.fetch;
let expressions = Arc::clone(&self.expr);
let stream = futures::stream::once(futures::future::lazy(move |_| {
+ let timer = metrics.elapsed_compute().timer();
Review Comment:
Ah, I think I missed the fact the timer is in the future 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
