rich7420 opened a new pull request, #5895: URL: https://github.com/apache/datafusion-comet/pull/5895
## Which issue does this PR close? Part of #4616. ## Rationale for this change The `lpad` and `rpad` tests do not verify routing with the codegen dispatcher disabled. Their global dispatcher counters also do not identify which expression ran. ## What changes are included in this PR? Check both dispatcher settings in the existing tests. Supported argument shapes must stay native; unsupported shapes must dispatch or fall back with the disabled-dispatcher reason. Replace global counters with expression-specific assertions and remove the redundant `allowIncompatible` loop. ## How are these changes tested? All four routing tests pass locally on Spark 4.1 after rebasing, covering 20 query/configuration combinations and comparing results with Spark. Injected routing regressions are caught for both expressions. [Fork CI](https://github.com/rich7420/datafusion-comet/actions/runs/34691737704) passed before the rebase and configuration-loop cleanup. CI for the revised head is pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
