alamb commented on PR #12063:
URL: https://github.com/apache/datafusion/pull/12063#issuecomment-2302727433
> Weird logictest are passing locally also the error cause is wrong.
Likewise I found it strange the tests were passing locally for me.
@dharanad, I took the liberty of merging up from main to get this branch to
pass and wrote a few more tests. These tests actually uncovered a bug (`value
|| NULL` --> `NULL` but the previous implementation would return `value`)
I also made a small performance improvement by avoiding allocating a new
`String` for each row
I also found another bug which I will file separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
