cdelmonte-zg commented on code in PR #25196:
URL: https://github.com/apache/datafusion/pull/25196#discussion_r4000058647
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -1246,7 +1251,12 @@ impl AggregateUDFImpl for LastValue {
)
.into(),
];
- fields.extend(args.ordering_fields.iter().cloned());
+ fields.extend(args.ordering_fields.iter().enumerate().map(|(idx,
field)| {
Review Comment:
Moved the logic into an helper. As regards the naming scheme, I think you
are right. I kept the field name mainly to make debugging easier, but now it is
not really needed anymore. Good point :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
