LucaCappelletti94 commented on code in PR #2504:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2504#discussion_r4000902678
##########
src/ast/ddl.rs:
##########
@@ -2991,6 +2991,8 @@ pub struct CreateTable {
/// Hive: Table clustering column list.
///
<https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-CreateTable>
pub clustered_by: Option<ClusteredBy>,
+ /// DuckDB partition expressions, distinct from Hive partition columns.
Review Comment:
add documentation link
##########
src/dialect/mod.rs:
##########
@@ -769,6 +763,11 @@ pub trait Dialect: Debug + Any {
false
}
+ /// Uses expressions rather than column declarations in `PARTITIONED BY`.
Review Comment:
may require some reference SQL doc link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
