edubraqd commented on PR #24905: URL: https://github.com/apache/datafusion/pull/24905#issuecomment-5656212580
Addressed both review points in 9041f8d (rebased on current `main`): - `data_page_row_count_limit = 0` is now rejected too. I checked against parquet 59.2 with a 100-row `Int32` column: `write_batch_size = 0` hangs the writer on a non-nullable column and `data_page_row_count_limit = 0` hangs it on a nullable one (the column writer picks one or the other as its batch size depending on whether the levels are compact, and a zero batch size never advances). Test extended for the new case. - The `config.rs` docstrings for every checked option now state the valid range (`must be greater than 0`, `strictly between 0 and 1`, `max_chunk_size` > `min_chunk_size`), and `docs/source/user-guide/configs.md` was regenerated with `dev/update_config_docs.sh`. - The embedded whitespace in the error strings is gone. This PR was closed with the batch in https://github.com/apache/datafusion/pull/24893#issuecomment-5640786567; I am not reopening it myself. @alamb, once #24916 lands, this would be my pick for the next one if you are willing to take it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
