sam-1112 commented on PR #5835: URL: https://github.com/apache/datafusion-comet/pull/5835#issuecomment-5657776596
Thanks for the detailed review. I removed `CodegenDispatchFallback` and the unreachable unsupported-reason override from `CometSha1`, then regenerated the expression docs so `sha`/`sha1` are Native again. I also added separate multi-argument `hash` and `xxhash64` tests containing a wide decimal and forced the method-splitting path via `spark.sql.codegen.methodSplitThreshold`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
