2010YOUY01 commented on code in PR #23833: URL: https://github.com/apache/datafusion/pull/23833#discussion_r4001905056
########## benchmarks/sql_benchmarks/asof_join/scratch/.gitignore: ########## @@ -0,0 +1 @@ +*.parquet Review Comment: Since it's leaving benchmark data in the directory, we could put it in the `benchmarks/data/` folder to keep large benchmark files together to make it easier to maintain. To do that, data should be generated with ``` # Generate test data in `benchmarks/data/` ./bench.sh data asof_join # later benchmark queries should only register the generated parquet file, and won't generate them again ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
