LinSimon-901101 commented on PR #5889: URL: https://github.com/apache/datafusion-comet/pull/5889#issuecomment-5660855745
Thanks for pointing out the issue; the scalar branch of GetStructField now returns ColumnarValue::Scalar, allowing DataFusion to broadcast the value to the consuming batch's row count. The regression test now uses a single Parquet file with 1,024 rows and fails without the fix, with additional Rust coverage for batch sizes 0/1/4, NULLs, and nested structs. Code: [get_struct_field.rs:102–108](https://github.com/apache/datafusion-comet/blob/fb658a6918149d5b328c2cf5dea10c002b9d75ab/native/spark-expr/src/struct_funcs/get_struct_field.rs#L102-L108). Tests: the 1,024-row regression in [CometExecSuite.scala:2300](https://github.com/apache/datafusion-comet/blob/fb658a6918149d5b328c2cf5dea10c002b9d75ab/spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala#L2300), and batch-size/NULL/nested-struct coverage in [get_struct_field.rs:148–244](https://github.com/apache/datafusion-comet/blob/fb658a6918149d5b328c2cf5dea10c002b9d75ab/native/spark-expr/src/struct_funcs/get_struct_field.rs#L148-L244). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
