wiedld commented on code in PR #12086:
URL: https://github.com/apache/datafusion/pull/12086#discussion_r1725781724
##########
datafusion/common-runtime/Cargo.toml:
##########
@@ -37,3 +37,6 @@ path = "src/lib.rs"
[dependencies]
tokio = { workspace = true }
+
+[dev-dependencies]
+tokio = { version = "1.36", features = ["rt", "rt-multi-thread", "time"] }
Review Comment:
Turns out the the `rt-multi-thread` feature is not supported on wasm, and
[CI was
failing](https://github.com/influxdata/arrow-datafusion/actions/runs/10497744745/job/29081242552).
```
error: Only features sync,macros,io-util,rt,time are supported on wasm.
-->
/usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.39.3/src/lib.rs:467:1
|
467 | compile_error!("Only features sync,macros,io-util,rt,time are
supported on wasm.");
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
