jayzhan211 commented on code in PR #25288:
URL: https://github.com/apache/datafusion/pull/25288#discussion_r4006084358
##########
datafusion/expr/src/udaf.rs:
##########
@@ -1713,6 +1736,31 @@ pub enum SetMonotonicity {
NotMonotonic,
}
+/// How an aggregate function treats the `DISTINCT` modifier.
+///
+/// Mathematically, `Ignored` means the function's merge operation is
+/// idempotent (its state forms a semilattice): f(S ⊎ S) = f(S), so
+/// removing duplicates from the input cannot change the result.
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[non_exhaustive]
+pub enum DistinctHandling {
+ /// The result is the same with or without `DISTINCT`, so the planner
+ /// is free to drop it. `min`, `max`, `bool_and`, `bit_or`, ...
+ Ignored,
Review Comment:
What do you think
Ignored -> Insensitive
Honored -> Sensitive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
