dwsmith1983 commented on code in PR #5365:
URL: https://github.com/apache/datafusion-comet/pull/5365#discussion_r4007012049
##########
native/core/Cargo.toml:
##########
@@ -103,12 +106,25 @@ datafusion-functions-nested = { version = "55.1.0" }
[features]
backtrace = ["datafusion/backtrace"]
-default = ["hdfs-opendal"]
+default = ["hdfs-opendal", "delta"]
hdfs-opendal = ["opendal", "object_store_opendal", "hdfs-sys"]
jemalloc = ["tikv-jemallocator", "tikv-jemalloc-ctl"]
-# Delta Lake integration. When enabled, links the `comet-contrib-delta` crate
-# into `libcomet` and activates the `OpStruct::DeltaScan` dispatcher arm.
-# Default builds carry zero Delta surface.
+# Native Delta Lake scan support for the JVM-planned path
(contrib/delta-spark).
+# In the default set: inert at runtime unless the contrib jar is on the
+# classpath (ServiceLoader) AND spark.comet.scan.delta.enabled is set, so it
+# cannot affect non-Delta scans. Opt out with --no-default-features for slim
Review Comment:
> Could this state the rationale directly rather than pointing at the PR
review?
Rewritten: in the default set so trying the contrib needs only the jar and
the config, inert without both, no new crates since `roaring` and `crc32fast`
are already in the tree. The footprint number now lives only in
`dev/verify-contrib-delta-gate.sh`, which the comment points at.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
