AnuragRaut08 commented on PR #25297: URL: https://github.com/apache/datafusion/pull/25297#issuecomment-5668096172
The lower patch coverage here is mainly due to the direct-construction branches not all being exercised by a single focused test path. The existing logical-plan roundtrip coverage does exercise the affected Projection, Filter, Window, Aggregate, and Sort decode paths, and those tests pass with this change. I also ran the full `datafusion-proto` integration test target: 254 tests passed. The 7 failures are unrelated Parquet tests caused by the missing `parquet-testing` test data/submodule. I don't think adding coverage-only tests would provide meaningful additional validation for this change; the important behavior is already covered by the existing logical-plan roundtrip tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
