goutamadwant commented on code in PR #24766:
URL: https://github.com/apache/datafusion/pull/24766#discussion_r4011146518
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -205,8 +211,12 @@ impl Display for Partitioning {
pub struct RangePartitioning {
/// Ordered partitioning key.
ordering: LexOrdering,
- /// Boundaries between adjacent partitions.
- split_points: Vec<SplitPoint>,
+ /// Maximum-resolution boundaries used to derive split points.
+ samples: Arc<[SplitPoint]>,
+ /// Effective boundaries for the current partition count.
+ split_points: Arc<[SplitPoint]>,
+ /// Number of effective partitions.
+ partition_count: usize,
Review Comment:
makes sense @stuhood removed the stored partition_count field; it is now
derived from split_points.len() + 1. Protobuf and FFI still retain the
effective count needed to reconstruct the selected layout from the stored
samples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
