jayzhan211 commented on code in PR #12096:
URL: https://github.com/apache/datafusion/pull/12096#discussion_r1726365405
##########
datafusion/core/src/physical_optimizer/combine_partial_final_agg.rs:
##########
@@ -229,7 +230,7 @@ mod tests {
fn partial_aggregate_exec(
input: Arc<dyn ExecutionPlan>,
group_by: PhysicalGroupBy,
- aggr_expr: Vec<Arc<dyn AggregateExpr>>,
+ aggr_expr: Vec<Arc<AggregateFunctionExpr>>,
Review Comment:
If `AggregateFunctionExpr` is not cloned massively in the core workflow, we
could remove `Arc`, similar to that we doesn't wrap `Arc` for `Expr`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
