sunchao commented on code in PR #5565:
URL: https://github.com/apache/datafusion-comet/pull/5565#discussion_r4012356127
##########
native/shuffle/src/writers/shuffle_block_writer.rs:
##########
@@ -233,10 +237,10 @@ impl ShuffleBlockWriter {
&self,
batch: &RecordBatch,
output: &mut W,
- compression_context: &mut IpcWriteContext,
+ codec_context: &mut ShuffleCodecContext,
Review Comment:
### Correctness
[P2] Migrate the reader benchmark to the new context type
The rebase brought in
[`benches/shuffle_reader.rs`](https://github.com/apache/datafusion-comet/blob/2ecbbc2c53dee9eb21fafc51fdff250c20b8f13b/native/shuffle/benches/shuffle_reader.rs#L74-L81),
where `encode_block` still constructs `IpcWriteContext` and passes `&mut
context` to this method. This parameter now requires the distinct
`ShuffleCodecContext` type, so the reader benchmark cannot type-check. It is an
unconditional `[[bench]]` target in the shuffle crate, which is a default
workspace member; this affects `cargo check --benches` and `cargo clippy
--all-targets --workspace`. Please update its import and context initialization
to `ShuffleCodecContext`, as already done in the writer benchmark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
