rich7420 opened a new pull request, #5953:
URL: https://github.com/apache/datafusion-comet/pull/5953

   ## Which issue does this PR close?
   
   Related to #5831; builds on the fixes in #5828.
   
   ## Rationale for this change
   
   A new constructor field can be omitted from a native operator's handwritten 
`equals`, allowing exchange reuse between different plans. A structural guard 
makes each omission require an explicit decision.
   
   ## What changes are included in this PR?
   
   Discover native plan classes and check constructor parameters against reads 
in `equals` or documented exclusions. Add a negative fixture and register the 
suite in Linux and macOS CI.
   
   `CometBroadcastExchangeExec.mode` is explicitly excluded because Comet 
broadcasts mode-independent Arrow batches. This preserves its current reuse 
behavior; the guard checks field coverage rather than proving equality 
semantics.
   
   ## How are these changes tested?
   
   Both `CometPlanEqualitySuite` tests pass in the local verification run on 
Spark 4.1.3 / JDK 21 after rebasing onto main. Formatting and Scalastyle 
passed. Cross-version fork CI passed before rebasing. The PR contains only the 
guard and CI registration; #5828's production fixes are already on main.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to