andygrove commented on issue #5704: URL: https://github.com/apache/datafusion-comet/issues/5704#issuecomment-5682441772
Resolved by #5904. The full SF1 `CometTPCHQuerySuite` passes on current main with the original 2 GiB off-heap budget, with both debug and release native libraries, so the increase to 4 GiB was not needed for this configuration and the suite is back at 2 GiB. With no user-visible change in memory requirements there is nothing to add to the changelog. One caveat from that PR: it did not measure the original DataFusion 55 upgrade commit or other workloads, so whether the bump was ever transiently necessary is unknown. That is historical at this point and not worth chasing separately. If a real memory regression on DataFusion 55 shows up elsewhere it should get its own issue with the workload attached. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
