ozankabak commented on PR #12096: URL: https://github.com/apache/datafusion/pull/12096#issuecomment-2304143624
Thanks for working on this @lewiszlw . As @berkaysynnada mentioned, let's keep all the methods please. BTW, I don't see a way to remove with_new_expressions without breaking downstream. We also plan to contribute some code upstream in the near future that uses this functionality, so it is probably here for good. However, it may be possible to remove all_expressions (the functionality may be implemented with existing methods - though I should verify that). We can explore if that is possible and give you an indication next week so we can plan the follow on work. Thanks again for the awesome collaboration 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
