rich7420 commented on code in PR #5891:
URL: https://github.com/apache/datafusion-comet/pull/5891#discussion_r4017108549
##########
native/core/src/parquet/parquet_exec.rs:
##########
@@ -221,6 +222,11 @@ pub(crate) fn init_datasource_exec(
_ => Arc::new(parquet_source),
};
+ let file_source = if spark_parquet_options.checked_timestamp_overflow {
+ ParquetErrorContext::wrap(file_source)
Review Comment:
This wrapper makes `downcast_to_file_source::<ParquetSource>()` in
`dynamic_filter.rs` return `None`, so wrapped scans lose runtime reader-filter
pushdown. That causes the [Rust CI
failure](https://github.com/apache/datafusion-comet/actions/runs/34953412077/job/104331959346).
I reproduced it locally; recognizing `ParquetErrorContext` in that type
check makes the existing test pass. Please update the check while preserving
this wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
