andygrove commented on code in PR #5963:
URL: https://github.com/apache/datafusion-comet/pull/5963#discussion_r4017781339
##########
.github/workflows/ci.yml:
##########
@@ -204,6 +220,20 @@ jobs:
# every output true for this event so a manual run can exercise
# any gated job.
:
+ elif [[ "$EVENT_NAME" == "schedule" ]]; then
+ # Same: the nightly tests main as it stands, so there is nothing
+ # to diff and compute-changes.py runs the whole nightly tier. It
+ # skips when HEAD predates the previous night's run, so a quiet
+ # weekend does not re-test the same tree three times. The slack
+ # covers scheduling jitter; if a nightly fails for an
+ # infrastructure reason and nothing lands the next day, trigger
+ # ci.yml by hand instead.
+ head_ts=$(git log -1 --format=%ct)
+ age=$(( $(date +%s) - head_ts ))
+ if [[ "$age" -gt $(( 24 * 3600 + 1800 )) ]]; then
+ echo "HEAD is $(( age / 3600 ))h old; nothing has landed since
the last nightly"
+ export NIGHTLY_STALE=true
Review Comment:
Done in 8533d0cf0: `dev/ci/nightly-base.py` now looks up the head sha of the
last successful scheduled run through the Actions API and the nightly diffs
against that, so every commit is covered by exactly one nightly and a red night
keeps its commits in scope until a green one supersedes it. The time window is
only the fallback for the first run, an API error, or a base that is no longer
on main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
