LucaCappelletti94 commented on code in PR #2512:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2512#discussion_r4019457734
##########
tests/sqlparser_common.rs:
##########
@@ -4848,8 +4848,10 @@ fn parse_create_table_as_table() {
let expected_query1 = Box::new(Query {
with: None,
body: Box::new(SetExpr::Table(Box::new(Table {
+ only: false,
Review Comment:
Maybe tests where these new attributes are not all `false` could help
increase test coverage and avoid regressions.
##########
tests/sqlparser_postgres.rs:
##########
@@ -9953,3 +9953,10 @@ fn parse_insert_by_name_keywords_as_table_and_alias() {
statement => panic!("Expected INSERT statement, got: {statement:?}"),
}
}
+
+#[test]
+fn parse_table_command() {
+ pg().verified_stmt("TABLE customers ORDER BY contact_name LIMIT 1");
Review Comment:
Maybe these should be `pg_and_generic`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
