alamb commented on code in PR #12102:
URL: https://github.com/apache/datafusion/pull/12102#discussion_r1726770062
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -883,7 +893,7 @@ fn both_numeric_or_null_and_numeric(lhs_type: &DataType,
rhs_type: &DataType) ->
///
/// Not all operators support dictionaries, if `preserve_dictionaries` is true
/// dictionaries will be preserved if possible
-fn dictionary_coercion(
+fn dictionary_comparison_coercion(
lhs_type: &DataType,
rhs_type: &DataType,
preserve_dictionaries: bool,
Review Comment:
In my mind, most single argument functions / operations / coercions would
preserve dictionary encoding if possible as that would keep the data encoded in
a more efficent form (dictionary) longer
For example `substr(dict_column, 3, 10)` would ideally produce a
`Dictionary` as output (after applying the function to the values)
However, most of our functions don't know how to work with Dictionary
arrays, so this would be a larger change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
