andygrove commented on code in PR #5934:
URL: https://github.com/apache/datafusion-comet/pull/5934#discussion_r4020221925
##########
native/core/src/execution/jni_api.rs:
##########
@@ -132,6 +132,18 @@ fn log_jemalloc_usage() {
log_memory_usage("jemalloc_allocated", allocated.read().unwrap() as u64);
}
+/// Reports the bytes currently handed out by the Rust global allocator,
process-wide.
+///
+/// Logged alongside the per-thread pool reservations so the two can be
compared directly: a large
+/// and growing excess is native memory the pool is not accounting for.
+#[cfg(feature = "alloc-accounting")]
+fn log_native_allocated() {
Review Comment:
The zero-reservation boundary is fixed in 5a4334a. The comparison now waits
only until the trace has produced at least one pool sample, so an observed zero
reservation is compared against like any other value: a zero pool sample with
32 MiB `native_allocated` reports 32 MiB excess, and reservations falling from
8 MiB to zero under a steady 32 MiB report a 32 MiB peak. When the trace never
carries a pool sample the tool says so instead of reporting that allocation
never exceeded reservations. The same commit reflows the `tracing.md` table
that failed the Preflight prettier check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
