kosiew commented on code in PR #25030:
URL: https://github.com/apache/datafusion/pull/25030#discussion_r4025059998
##########
datafusion/core/tests/physical_optimizer/filter_pushdown.rs:
##########
@@ -3059,6 +3059,92 @@ fn
test_hashjoin_dynamic_filter_requires_probe_consumer() {
}
}
+#[tokio::test]
+async fn test_nlj_dynamic_filter_pushdown_from_hashjoin() {
Review Comment:
Could we add an end-to-end outer or mark NLJ case with unmatched rows? The
unit test already covers the routing decisions for all join types, but the
integration test only executes an inner NLJ. An unmatched-row case would give
us some extra protection around the key safety invariant here: dynamic filters
should never be routed to a non-preserved input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
