alamb commented on code in PR #25278: URL: https://github.com/apache/datafusion/pull/25278#discussion_r4029131881
########## datafusion/sqllogictest/test_files/merge_into.slt: ########## @@ -241,6 +241,18 @@ statement error DataFusion error: This feature is not implemented: MERGE INSERT merge into target using source on target.id = source.id when not matched then insert row; +statement error DataFusion error: This feature is not implemented: MERGE UPDATE SET \* is not supported +merge into target using source on target.id = source.id +when matched then update set *; + +statement error DataFusion error: This feature is not implemented: MERGE INSERT \* is not supported +merge into target using source on target.id = source.id +when not matched then insert *; + +statement error DataFusion error: This feature is not implemented: MERGE DO NOTHING is not supported +merge into target using source on target.id = source.id Review Comment: Do you mean why is `DO NOTHING` part of SQL? I think it is supported by POSTRGES, see https://www.postgresql.org/docs/current/sql-merge.html Which says > When DO NOTHING is specified, the source row is skipped. Since actions are evaluated in their specified order, DO NOTHING can be handy to skip non-interesting source rows before more fine-grained handling. 🤷 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
