stantheman0128 commented on PR #1671: URL: https://github.com/apache/datafusion-python/pull/1671#issuecomment-5702190707
Thanks for merging main in. That surfaced an `F811`, and it came from the merge rather than from the original change: upstream moved `QueryPlannerExportable` into `datafusion/extensions.py` and `context.py` now imports it, while this branch still carried the old class body. Removed in 1a329ca. I kept `ExtensionOptionsExportable` and `TaskContextProviderExportable` in `context.py` rather than moving them to `extensions.py`, since `ArrowStreamExportable`, `ArrowArrayExportable`, `TableProviderExportable` and `PhysicalOptimizerRuleExportable` still live there. Happy to move them if you would rather the FFI protocols all sit in one module. Verified against what lint-python actually runs: `ruff check python/`, `ruff format --check python/`, and `codespell --toml pyproject.toml` at the pinned 2.4.1. All clean. The workflow runs need approving again for this commit. Every push from a first-time contributor lands at `action_required`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
