Blizzara opened a new pull request, #12112: URL: https://github.com/apache/datafusion/pull/12112
## Which issue does this PR close? ## Rationale for this change Previously, Substrait didn't have a type & literal for the intervals that combine year/month and day/time, so DF had to use a custom type to support those. https://github.com/substrait-io/substrait/pull/665 however added support for IntervalCompound, which is a superset of DF's IntervalMonthDayNano - so we can switch over. ## What changes are included in this PR? Add support for consuming Substrait's IntervalCompound type/literals (in addition to existing UDTs, for backwards compatibility) Switch Substrait producing to produce IntervalCompound type/literals ## Are these changes tested? Tested through existing unit tests. However, as we now don't produce any UDTs, we cannot easily test the UDT-producing code anymore. <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? Substrait now produces IntervalCompound types instead of interval-month-day-nano UDTs. Both types can be consumed. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
