timsaucer opened a new pull request, #1746: URL: https://github.com/apache/datafusion-python/pull/1746
# Which issue does this PR close? Closes #1745. # Rationale for this change `crates/core/src/expr/indexed_field.rs` has not been part of the crate since b5446efbc2e50fb017454173f6b11e4fad53fe5a (#728, the DataFusion 39 upgrade), which removed both `pub mod indexed_field;` and the `m.add_class::<indexed_field::PyGetIndexedField>()` registration from `crates/core/src/expr.rs` after upstream replaced `Expr::GetIndexField` with the `FieldAccessor` trait. The file was left on disk. It is never compiled, and it imports `GetIndexedField`, a type that no longer exists in DataFusion, so it would not compile if it were wired back in. The orphan is actively costly. The `rust-fmt` pre-commit hook runs `cargo +nightly fmt --all --` with `pass_filenames: true`, which hands rustfmt the path directly and formats the file regardless of the module tree; CI runs stable `cargo fmt --all --check` with no filenames, which only walks `mod` declarations and never reaches it. The two disagree on one match arm, so the hook rewrites the file on every Rust-touching commit and contributors revert the churn by hand. Separately, #1667 replaced a `todo!()` in `PyGetIndexedField::key` with a real error — a change that has had no effect since June 2024 because the code is not built. # What changes are included in this PR? Deletes `crates/core/src/expr/indexed_field.rs`. Nothing else changes. No references to `indexed_field`, `IndexedField`, or `PyGetIndexedField` remain anywhere in the repository. The only in-crate helper the file imported, `py_unsupported_variant_err`, has several other callers in `crates/core/src/expr.rs` and is unaffected. # Are there any user-facing changes? No. `datafusion.expr.GetIndexedField` has not been exported since the DataFusion 39 upgrade, so nothing reachable from Python changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
