osipovartem commented on code in PR #25381:
URL: https://github.com/apache/datafusion/pull/25381#discussion_r4029861349


##########
datafusion/sqllogictest/test_files/functions.slt:
##########
@@ -486,6 +486,35 @@ BAR Dictionary(Int32, Utf8)
 statement ok
 DROP TABLE upper_dictionary_test
 
+# upper and lower preserve input nullability in the planned schema
+statement ok
+CREATE TABLE case_nullability (a VARCHAR NOT NULL, b VARCHAR) AS VALUES ('Ab', 
NULL)
+
+statement ok
+CREATE TABLE case_nullability_out AS
+SELECT upper(a) AS ua, lower(a) AS la, upper(b) AS ub FROM case_nullability

Review Comment:
   Thanks. I replaced the CTAS-based schema check with direct `DESCRIBE SELECT` 
coverage. The test now checks both ordinary input nullability and nullability 
widened by a `LEFT JOIN`; it also retains the execution assertion that the 
widened value evaluates to `NULL`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to