andygrove commented on PR #23898: URL: https://github.com/apache/datafusion/pull/23898#issuecomment-5704175863
Thanks @amitvijapur, merged `main` in. The resolution keeps #24409's `pmod_decimal_result_type`, the `DataType::Null` passthrough and the decimal narrowing cast, and keeps `add_wrapping` plus the `Int8`/`Int16` widening for the `(r + n) % n` step, so main's plain `add` import is dropped. The overflow cases are covered by `test_pmod_integer_boundaries` and the `pmod(-1, -2147483648)` family in `pmod.slt`, so losing the wrapping behavior would now fail tests. The branch's unit tests were updated for the new `result_type` parameter. All `datafusion-spark` unit tests and all 244 `spark/` slt files pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
