adriangb commented on code in PR #25339:
URL: https://github.com/apache/datafusion/pull/25339#discussion_r4030721266
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -239,24 +244,27 @@ impl NullAwareMode {
num_keys: usize,
has_filter: bool,
) -> Result<Self> {
+ let correlated = num_keys > 1 || has_filter;
Review Comment:
Agreed, this is a bug in main:
```
main: R1 (with i.z < o.z) → 1 row R2 (equality only) → 1 row
PR: R1 → 1 row R2 → 1 row
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
