2010YOUY01 commented on code in PR #25371:
URL: https://github.com/apache/datafusion/pull/25371#discussion_r4037142644


##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -3055,8 +3057,7 @@ impl NestedLoopJoinStream {
                     Vec::with_capacity(filter.column_indices().len());

Review Comment:
   I don't fully understand what coverage is missing. At least the coverage 
report looks okay: 
https://github.com/apache/datafusion/pull/25371#issuecomment-5695975185
   
   If you can come up with a concrete test case, I'm happy to add it. More test 
cases are always a win.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to