sunchao commented on code in PR #5403: URL: https://github.com/apache/datafusion-comet/pull/5403#discussion_r4041360125
########## spark/src/test/resources/sql-tests/expressions/array/array_min.sql: ########## @@ -49,16 +49,16 @@ INSERT INTO test_array_min_double VALUES query SELECT array_min(arr) FROM test_array_min_double --- Spark treats +0.0 and -0.0 as equal and returns +0.0; Comet returns -0.0. --- Surfaced by https://github.com/apache/datafusion-comet/issues/5271 +-- Spark preserves the first equal zero (+0.0 here); the native minimum returns -0.0. +-- Native parity is tracked by https://github.com/apache/datafusion-comet/issues/5401. statement CREATE TABLE test_array_min_dbl_negzero(arr array<double>) USING parquet statement INSERT INTO test_array_min_dbl_negzero VALUES (array(0.0, double('-0.0'), 1.0)) -query ignore(array_min signed-zero: Spark +0.0, Comet -0.0) +query ignore(https://github.com/apache/datafusion-comet/issues/5401) Review Comment: The signed-zero cases are now published as ordinary native `query` assertions rather than ignored tests, so a fallback or result mismatch fails the test. The separate non-default-collation fixtures now use `expect_dispatch(...)` with codegen enabled, following the later review request; dispatcher-disabled collation fallback is covered separately in `CometArrayExpressionSuite` with a checked fallback reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
