dwsmith1983 commented on PR #5854: URL: https://github.com/apache/datafusion-comet/pull/5854#issuecomment-5731647646
> I'd land this PR first, then #5867 rebased onto it, and close #5844 and #5846 as superseded. Fine with either order as long as the nondeterministic-child gate lands with the `LAST_WIN` change; sunchao's `IF(monotonically_increasing_id() % 2 = 0, ...)` reproduction above is exactly the case the gate declines. If this PR goes first, lift `NullGuardSupport.nondeterministicChild` into `CometMapFromArrays` here and I will rebase #5867 onto it, keeping `map_from_arrays_nondeterministic_child.sql` and dropping the two dispatch assertions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
