sunchao commented on code in PR #5957:
URL: https://github.com/apache/datafusion-comet/pull/5957#discussion_r4049142986
##########
spark/src/test/scala/org/apache/comet/parquet/CometParquetWriterSuite.scala:
##########
@@ -903,6 +1039,68 @@ class CometParquetWriterSuite extends
CometParquetWriterTestBase {
}
}
+ private def deletePath(path: String): Unit = {
+ def delete(file: File): Unit = {
+ if (file.isDirectory) {
+ Option(file.listFiles()).foreach(_.foreach(delete))
+ }
+ file.delete()
+ }
+ delete(new File(path))
+ }
+
+ /**
+ * Captures the execution plan during a write operation.
+ *
+ * @param writeOp
+ * The write operation to execute (takes output path as parameter)
+ * @param outputPath
+ * The path to write to
+ * @return
+ * The captured execution plan
+ */
+ private def captureWritePlan(writeOp: String => Unit, outputPath: String):
SparkPlan = {
Review Comment:
### Correctness
[P1] Remove the duplicate helpers after the base-class extraction
Could you remove this retained `captureWritePlan` and
`assertNoCometNativeWriteExec` at line 1123, and use the inherited
implementations? The rebased suite now extends `CometParquetWriterTestBase`,
which already defines both methods as `protected`. These `private` declarations
override them with weaker access, so Spark test compilation fails before any
suite can run. I reproduced both compiler errors with the exact signatures and
inheritance on Scala 2.12.18 and 2.13.17. Removing the duplicate declarations
makes the isolated control compile. Their bodies already match the inherited
implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
