sunchao commented on code in PR #6021:
URL: https://github.com/apache/datafusion-comet/pull/6021#discussion_r4050242299
##########
.github/workflows/docs.yaml:
##########
@@ -49,6 +49,17 @@ jobs:
java-version: '17'
cache: 'maven'
+ - name: Setup Node
+ uses: actions/setup-node@v7
+ with:
+ node-version: '24'
+
+ - name: Install mermaid-cli
+ # Draws the ```mermaid fences into SVG at build time. Without mmdc on
PATH the build
+ # still succeeds but silently drops every diagram, so it is installed
unconditionally.
+ # See mermaid_output_format in docs/source/conf.py for why the browser
cannot draw them.
+ run: npm install -g @mermaid-js/[email protected]
Review Comment:
### Correctness
[P2] Configure Chromium for the Ubuntu 24.04 runner
Could you add a sandbox-compatible browser launch and a small render check
here? `mmdc` 11.17.0 launches Puppeteer's downloaded `chrome-headless-shell` by
default. The runner's preinstalled Chrome and `CHROME_BIN` do not select that
executable, and this workflow supplies no `PUPPETEER_EXECUTABLE_PATH`,
Puppeteer config, or AppArmor profile.
[This exact CLI release's
CI](https://github.com/mermaid-js/mermaid-cli/blob/0f792feed2fb69ab010c4149f733ede1871f706f/.github/workflows/test.yml#L61-L71)
uses the Chrome AppArmor profile because Ubuntu 24.04 otherwise blocks
Puppeteer. [Runner-image maintainers confirmed that AppArmor remains
enabled](https://github.com/actions/runner-images/issues/10015#issuecomment-4183129225).
With the default downloaded browser, the source-supported expected result is
`No usable sandbox!`. I have not reproduced that Linux launch locally.
This also fails quietly at publication: [the extension turns a nonzero
renderer exit into a warning and skips the
diagram](https://github.com/mgaitan/sphinxcontrib-mermaid/blob/6e51230b4781f578efdc54af5bae0952e1627c53/sphinxcontrib/mermaid/__init__.py#L254-L312),
which I verified with a controlled failing subprocess. Our docs build does not
use `-W`, and the PR's docs job is skipped, so the successful checks do not
catch it. Please verify that the same Ubuntu runner produces all three SVGs
before allowing the publish step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
