sunchao commented on code in PR #6030: URL: https://github.com/apache/datafusion-comet/pull/6030#discussion_r4051557157
########## docs/source/contributor-guide/ci.md: ########## @@ -192,6 +192,11 @@ gh pr merge <number> --squash --auto The pull request's own checks do not have to be finished, though it is polite not to queue a pull request whose PR tier is red. +Approval is the mechanical requirement, not the whole of it. A non-trivial pull request should +also have been open for at least 24 hours before it is queued, so that reviewers in other time Review Comment: ### Correctness [P2] Start the queue wait when the PR is ready for review Could this say "at least 24 hours after it is ready for review" to match [the new policy](https://github.com/apache/datafusion-comet/blob/cc7a94ee919490229b65470490412a2b59dd761c/docs/source/contributor-guide/contributing.md#L48-L50) and the first design choice in the PR description? As written, a non-trivial PR opened as a draft on Monday, marked ready on Friday and approved immediately has already met this page's 24-hour condition. A committer following the queue instructions could therefore queue it without the review opportunity that the main section requires. The cross-link provides the intended rule, but this reminder restates it with a different starting event. Please use the readiness-based clock here too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
