2010YOUY01 commented on PR #24799: URL: https://github.com/apache/datafusion/pull/24799#issuecomment-5740003721
Thank you. I think we should only declare this property if we can demonstrate an optimization that actually uses it, for example: ```text GROUP BY a, b → GROUP BY a given the functional dependency a → b ``` Otherwise, I don’t think we need to make the property system complete for its own sake, the reason is it's we can't test it end-to-end to ensure its declared properly. And I don't know if the infra for such optimization is there, and if is it easy to trigger, if not we can leave it as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
