kosiew commented on code in PR #25489:
URL: https://github.com/apache/datafusion/pull/25489#discussion_r4060977581
##########
datafusion/physical-plan/src/joins/sort_merge_join/tests.rs:
##########
@@ -943,6 +943,124 @@ async fn join_left_different_columns_count_with_filter()
-> Result<()> {
Ok(())
}
+/// A filter whose intermediate schema lists a right column before a left one
+/// (the layout `JoinFilter::swap` produces when a join's inputs are swapped)
+#[tokio::test]
+async fn join_left_with_filter_columns_right_before_left() -> Result<()> {
+ // select *
+ // from t2
+ // left join t1 on t2.b1 = t1.b1 and t2.a2 > t1.a1
Review Comment:
Could we also add one three-column interleaving case, for example `Left,
Right, Left`? The new tests cover the swapped `Right, Left` layout nicely, but
this helper is meant to support arbitrary `column_indices` ordering. An
interleaving case would help protect that broader contract from accidentally
being changed back to grouping columns by side in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
